Skip to content

chore: fix JavaScript lint errors (issue #9812)#9813

Merged
kgryte merged 4 commits intostdlib-js:developfrom
nnyouung:feature/fix-lint-9812
Jan 26, 2026
Merged

chore: fix JavaScript lint errors (issue #9812)#9813
kgryte merged 4 commits intostdlib-js:developfrom
nnyouung:feature/fix-lint-9812

Conversation

@nnyouung
Copy link
Contributor

@nnyouung nnyouung commented Jan 18, 2026 •
edited
Loading

Resolves #9812

Description

What is the purpose of this pull request?

This pull request fixes JavaScript lint errors identified by the automated lint workflow.
Specifically, it:

  • Fixes ESLint rule violations in example and test files
  • Updates code to comply with stdlib JavaScript linting rules
  • Introduces no functional or behavioral changes

Related Issues

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@nnyouung
chore: fix JavaScript lint errors
09e7258 
Resolve ESLint rule violations in example and test files.

Fixes: stdlib-js#9812

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Jan 18, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 18, 2026

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Jan 19, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jan 26, 2026
@kgryte
Apply suggestions from code review
4db9a2b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte added 2 commits January 25, 2026 18:04
@kgryte
chore: disable lint rule
c16bda9 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
docs: fix example
c35391f 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte mentioned this pull request Jan 26, 2026
Closed
7 tasks
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 26, 2026

Coverage Report

Package Statements Branches Functions Lines
math/strided/special/besselj1-by $\color{green}197/197$
$\color{green}+100.00%$ 		$\color{green}5/5$
$\color{green}+100.00%$ 		$\color{green}2/2$
$\color{green}+100.00%$ 		$\color{green}197/197$
$\color{green}+100.00%$
strided/common $\color{green}100/100$
$\color{green}+100.00%$ 		$\color{green}3/3$
$\color{green}+100.00%$ 		$\color{green}0/0$
$\color{green}+100.00%$ 		$\color{green}100/100$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte merged commit 225a1d9 into stdlib-js:develop Jan 26, 2026
12 checks passed
@kgryte
Copy link
Member

kgryte commented Jan 26, 2026

Thank you for your contribution and congratulations on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@nnyouung @stdlib-bot @kgryte